Rails 6.1: Fix the quoting of ActiveModel attributes #885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidanharan
force-pushed
the
quoting-attribute
branch
from
d47f172 to
d9d09b0
Compare
aidanharan
changed the title
aidanharan
changed the title
aidanharan
changed the title
aidanharan
pushed a commit
to aidanharan/activerecord-sqlserver-adapter
that referenced
this pull request
Apr 20, 2021
wpolicarpo
pushed a commit
that referenced
this pull request
Apr 20, 2021
lavika
pushed a commit
to lavika/activerecord-sqlserver-adapter
that referenced
this pull request
Sep 26, 2023
…#885) * Fix when quoting ActiveModel::Attribute * Updated changelog Co-authored-by: Aidan Haran <aharan@fusioneer.com>
lavika
pushed a commit
to lavika/activerecord-sqlserver-adapter
that referenced
this pull request
Sep 26, 2023
…-sqlserver#896) Co-authored-by: Aidan Haran <aharan@fusioneer.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fixes the
TypeError: can't quote ActiveRecord::Relation::QueryAttributeerrors in the tests.This is an alternative fix to #883